[PATCH v3 libdrm 2/2] Add drmModeGetFB2

Daniel Stone daniel at fooishbar.org
Fri Jan 31 19:44:16 UTC 2020


Hi Juston,

On Thu, 23 Jan 2020 at 00:37, Juston Li <juston.li at intel.com> wrote:
> +drm_public void drmModeFreeFB2(drmModeFB2Ptr ptr)
> +{
> +       if (!ptr)
> +               return;
> +
> +       /* we might add more frees later. */
> +       drmFree(ptr);

I do not recognise this comment, and since free(NULL) is defined to be
safe, this entire function can be defined as drmFree(ptr) without the
comment or early return.

I would like this to be changed before merging. After the revision,
this patch is:
Signed-off-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel


More information about the dri-devel mailing list