[PATCH v7 02/13] dt-bindings: panel: Convert rocktech, jh057n00900 to yaml
Sam Ravnborg
sam at ravnborg.org
Fri Jul 3 05:11:55 UTC 2020
Hi Ondrej.
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel at 0: '#address-cells', '#size-cells', 'port at 0' do not match any of the regexes: 'pinctrl-[0-9]+'
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel at 0: 'vcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel at 0: 'iovcc-supply' is a required property
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel at 0: 'reset-gpios' is a required property
>
> Paths look bogus ^^^^
>
> It should be .../rocktech,jh057n00900.yaml: ...
The example in nwl-dsi.yaml contains:
compatible = "rocktech,jh057n00900";
So the example is checked against your updated binding.
And the binding check fails because the example is no longer valid.
This needs to be fixed as we do not wat to introduce new errors.
Either the example or the binding needs the fix.
Sam
>
> regards,
> o.
>
> >
> > See https://patchwork.ozlabs.org/patch/1320690
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure dt-schema is up to date:
> >
> > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
> >
> > Please check and re-submit.
> >
More information about the dri-devel
mailing list