[PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()

Xin He hexin.op at bytedance.com
Wed Jul 22 05:18:51 UTC 2020


Before setting shmem->pages to NULL, kfree() should
be called.

Signed-off-by: Xin He <hexin.op at bytedance.com>
Reviewed-by: Qi Liu <liuqi.16 at bytedance.com>
---
 drivers/gpu/drm/virtio/virtgpu_object.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c
index 6ccbd01cd888..703b5cd51751 100644
--- a/drivers/gpu/drm/virtio/virtgpu_object.c
+++ b/drivers/gpu/drm/virtio/virtgpu_object.c
@@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo)
 			}
 
 			sg_free_table(shmem->pages);
+			kfree(shmem->pages);
 			shmem->pages = NULL;
 			drm_gem_shmem_unpin(&bo->base.base);
 		}
-- 
2.21.1 (Apple Git-122.3)



More information about the dri-devel mailing list