[PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge
kernel test robot
lkp at intel.com
Wed Jul 22 21:25:39 UTC 2020
Hi Swapnil,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.8-rc6 next-20200722]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Swapnil-Jakhade/drm-Add-support-for-Cadence-MHDP-DPI-DP-bridge-and-J721E-wrapper/20200722-154322
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 3d9967039d4191b77f939ddc6c6ff4275df620c2)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/gpu/drm/bridge/cdns-mhdp-core.c:765:10: warning: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744073709551613 to 4294967293 [-Wconstant-conversion]
writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/bridge/cdns-mhdp-core.c:1378:2: error: implicit declaration of function 'phy_get_attrs' [-Werror,-Wimplicit-function-declaration]
phy_get_attrs(mhdp->phy, &attrs);
^
>> drivers/gpu/drm/bridge/cdns-mhdp-core.c:1384:20: error: no member named 'max_link_rate' in 'struct phy_attrs'
link_rate = attrs.max_link_rate;
~~~~~ ^
drivers/gpu/drm/bridge/cdns-mhdp-core.c:1709:10: warning: implicit conversion from 'unsigned long' to 'unsigned int' changes value from 18446744073709551613 to 4294967293 [-Wconstant-conversion]
writel(~CDNS_APB_INT_MASK_SW_EVENT_INT,
~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 2 errors generated.
vim +/phy_get_attrs +1378 drivers/gpu/drm/bridge/cdns-mhdp-core.c
1371
1372 static void cdns_mhdp_fill_host_caps(struct cdns_mhdp_device *mhdp)
1373 {
1374 unsigned int link_rate;
1375 struct phy_attrs attrs;
1376
1377 /* Get source capabilities based on PHY attributes */
> 1378 phy_get_attrs(mhdp->phy, &attrs);
1379
1380 mhdp->host.lanes_cnt = attrs.bus_width;
1381 if (!mhdp->host.lanes_cnt)
1382 mhdp->host.lanes_cnt = 4;
1383
> 1384 link_rate = attrs.max_link_rate;
1385 if (!link_rate)
1386 link_rate = drm_dp_bw_code_to_link_rate(DP_LINK_BW_8_1);
1387 else
1388 /* PHY uses Mb/s, DRM uses tens of kb/s. */
1389 link_rate *= 100;
1390
1391 mhdp->host.link_rate = link_rate;
1392 mhdp->host.volt_swing = CDNS_VOLT_SWING(3);
1393 mhdp->host.pre_emphasis = CDNS_PRE_EMPHASIS(3);
1394 mhdp->host.pattern_supp = CDNS_SUPPORT_TPS(1) |
1395 CDNS_SUPPORT_TPS(2) | CDNS_SUPPORT_TPS(3) |
1396 CDNS_SUPPORT_TPS(4);
1397 mhdp->host.lane_mapping = CDNS_LANE_MAPPING_NORMAL;
1398 mhdp->host.fast_link = false;
1399 mhdp->host.enhanced = true;
1400 mhdp->host.scrambler = true;
1401 mhdp->host.ssc = false;
1402 }
1403
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 75334 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200723/c4c97b5f/attachment-0001.gz>
More information about the dri-devel
mailing list