[PATCH] drm/omap: Use {} to zero initialize the mode

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Jul 24 21:06:46 UTC 2020


Hi Ville,

Thank you for the patch, and sorry for having let this issue slip
through the cracks :-S

On Fri, Jul 24, 2020 at 10:07:18PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The first member of drm_display_mode is no longer a structure, but
> the code is still using {{0}} to zero initialize it. Make that just
> {} so it works regardless of what lies inside.
> 
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> Fixes: 42acb06b01b1 ("drm: pahole struct drm_display_mode")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_connector.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_connector.c b/drivers/gpu/drm/omapdrm/omap_connector.c
> index 528764566b17..de95dc1b861c 100644
> --- a/drivers/gpu/drm/omapdrm/omap_connector.c
> +++ b/drivers/gpu/drm/omapdrm/omap_connector.c
> @@ -89,7 +89,7 @@ static enum drm_mode_status omap_connector_mode_valid(struct drm_connector *conn
>  				 struct drm_display_mode *mode)
>  {
>  	struct omap_connector *omap_connector = to_omap_connector(connector);
> -	struct drm_display_mode new_mode = { { 0 } };
> +	struct drm_display_mode new_mode = {};
>  	enum drm_mode_status status;
>  
>  	status = omap_connector_mode_fixup(omap_connector->output, mode,

-- 
Regards,

Laurent Pinchart


More information about the dri-devel mailing list