[PATCH 0/2] Small cleanups to ingenic-drm driver
Paul Cercueil
paul at crapouillou.net
Wed Jul 29 00:28:01 UTC 2020
Le mer. 29 juil. 2020 à 0:00, daniel at ffwll.ch a écrit :
> On Tue, Jul 28, 2020 at 10:17:36PM +0200, Sam Ravnborg wrote:
>> Hi Paul.
>>
>> On Tue, Jul 28, 2020 at 05:16:39PM +0200, Paul Cercueil wrote:
>> > Here are a few cleanups to the ingenic-drm driver.
>> > - some error paths were missing and have been added;
>> > - the mode validation has been moved to the .mode_valid helper
>> callback.
>> >
>> > Cheers,
>> > -Paul
>> >
>> > Paul Cercueil (2):
>> > drm/ingenic: Handle errors of drm_atomic_get_plane_state
>> > drm/ingenic: Validate mode in a .mode_valid callback
>>
>> Both looks fine, you can add my:
>> Reviewed-by: Sam Ravnborg <sam at ravnborg.org>
>>
>> I assume you will apply the patches.
>> Maybe wait for Daniel to take a look, he had some feedback on where
>> to add checks. I assume this is covered by the second patch.
>
> Yeah changelog for new versions would be great, but aside from that
> bickering patch 2 lgtm now.
This patchset is V1, I'm fixing issues you saw in the ingenic-drm
driver when reviewing a different patchset.
Thanks for the review, I'll apply now.
-Paul
>
More information about the dri-devel
mailing list