[PATCH 03/49] drm/ttm: split the mm manager init code

[Dave Airlie]

On Fri, 31 Jul 2020 at 15:51, Dave Airlie <airlied at gmail.com> wrote:
>
> On Fri, 31 Jul 2020 at 15:44, Sam Ravnborg <sam at ravnborg.org> wrote:
> >
> > Hi Dave.
> >
> > On Fri, Jul 31, 2020 at 02:04:34PM +1000, Dave Airlie wrote:
> > > From: Dave Airlie <airlied at redhat.com>
> > >
> > > This will allow the driver to control the ordering here better.
> > >
> > > Eventually the old path will be removed.
> > >
> > > Signed-off-by: Dave Airlie <airlied at redhat.com>
> > > ---
> > >  drivers/gpu/drm/ttm/ttm_bo.c    | 34 +++++++++++++++++++--------------
> > >  include/drm/ttm/ttm_bo_api.h    |  4 ++++
> > >  include/drm/ttm/ttm_bo_driver.h |  6 ++++++
> > >  3 files changed, 30 insertions(+), 14 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> > > index 041a0e73cd1b..a658fd584c6d 100644
> > > --- a/drivers/gpu/drm/ttm/ttm_bo.c
> > > +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> > > @@ -1503,35 +1503,41 @@ int ttm_bo_evict_mm(struct ttm_bo_device *bdev, unsigned mem_type)
> > >  }
> > >  EXPORT_SYMBOL(ttm_bo_evict_mm);
> > >
> > > -int ttm_bo_init_mm(struct ttm_bo_device *bdev, unsigned type,
> > > -                     unsigned long p_size)
> > > +void ttm_bo_init_mm_base(struct ttm_bo_device *bdev,
> > > +                      struct ttm_mem_type_manager *man,
> > > +                      unsigned long p_size)
> > >  {
> >
> > General comment for all the ttm/* changes.
> > It would be very nice with some nice explanations for the exported
> > functions, preferably in kernel-doc style.
> > In case someone that are more or less clueless (like me) would like
> > to understand how a function is to be used or maybe reviewing some
> > random code.
>
> Good point, I just need to make sure I don't add anything for
> something I remove later, but I should definitely add some for the new
> interfaces.

The version in my git branch has docs for all the new apis now.

Dave.