[PATCH v1 2/6] drm: panel-simple: add Seiko 70WVW2T 7" simple panel

[Doug Anderson]

Hi,

On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg <sam at ravnborg.org> wrote:
>
> The Seiko 70WVW2T is a discontinued product, but may be used somewhere.
> Tested on a proprietary product.
>
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Søren Andersen <san at skov.dk>
> Cc: Thierry Reding <thierry.reding at gmail.com>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> ---
>  drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index b067f66cea0e..8624bb80108c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = {
>         .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
>  };
>
> +static const struct drm_display_mode sii_70wvw2t_mode = {
> +       .clock = 33000,
> +       .hdisplay = 800,
> +       .hsync_start = 800 + 256,
> +       .hsync_end = 800 + 256 + 0,
> +       .htotal = 800 + 256 + 0 + 0,
> +       .vdisplay = 480,
> +       .vsync_start = 480 + 0,
> +       .vsync_end = 480 + 0 + 0,
> +       .vtotal = 480 + 0 + 0 + 45,

Important to have a "vrefresh"?


> +       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> +};
> +
> +static const struct panel_desc sii_70wvw2t = {
> +       .modes = &sii_70wvw2t_mode,
> +       .num_modes = 1,

Do we want "bpc = 6"?


> +       .size = {
> +               .width = 152,
> +               .height = 91,
> +       },
> +       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,

Should this be a 666 format?  Random internet-found data sheet says
262K colors...