drm/nouveau/clk/gm20b: Understanding challenges around gm20b_clk_new()

Markus Elfring Markus.Elfring at web.de
Wed Jun 3 05:04:37 UTC 2020


> Ben has explained this problem:
> https://lore.kernel.org/patchwork/patch/1249592/
> Since the caller will check "pclk" on failure, we don't need to free
> "clk" in gm20b_clk_new() and I think this patch is no longer needed.

* I am curious if it can become easier to see the relationships for
  these variables according to mentioned “destructor” calls.

* Did you notice opportunities to improve source code analysis
  (or software documentation) accordingly?

Regards,
Markus


More information about the dri-devel mailing list