[PATCH v6 3/5] drm/msm/dp: add displayPort driver support

kernel test robot lkp at intel.com
Tue Jun 9 06:47:57 UTC 2020


Hi Tanmay,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robh/for-next]
[also build test WARNING on drm-intel/for-linux-next linus/master v5.7 next-20200608]
[cannot apply to robclark/msm-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tanmay-Shah/dt-bindings-msm-dp-add-bindings-of-DP-DP-PLL-driver-for-Snapdragon/20200609-115137
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/gpu/drm/msm/dp/dp_aux.c:35:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
35 | static const char * const dp_aux_get_error(u32 aux_error)
|        ^~~~~
--
>> drivers/gpu/drm/msm/dp/dp_catalog.c:352:6: warning: no previous prototype for 'dump_regs' [-Wmissing-prototypes]
352 | void dump_regs(void * __iomem *base, int len)
|      ^~~~~~~~~
In file included from include/linux/printk.h:7,
from include/linux/kernel.h:15,
from include/linux/delay.h:22,
from drivers/gpu/drm/msm/dp/dp_catalog.c:8:
drivers/gpu/drm/msm/dp/dp_catalog.c: In function 'dump_regs':
>> include/linux/kern_levels.h:5:18: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'void **' [-Wformat=]
5 | #define KERN_SOH "001"  /* ASCII Start Of Header */
|                  ^~~~~~
include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
14 | #define KERN_INFO KERN_SOH "6" /* informational */
|                   ^~~~~~~~
include/linux/printk.h:305:9: note: in expansion of macro 'KERN_INFO'
305 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
|         ^~~~~~~~~
>> drivers/gpu/drm/msm/dp/dp_catalog.c:364:3: note: in expansion of macro 'pr_info'
364 |   pr_info("%08x: %08x %08x %08x %08x", base, x0, x4, x8, xc);
|   ^~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:364:15: note: format string is defined here
364 |   pr_info("%08x: %08x %08x %08x %08x", base, x0, x4, x8, xc);
|            ~~~^
|               |
|               unsigned int
At top level:
drivers/gpu/drm/msm/dp/dp_catalog.c:76:17: warning: 'vm_voltage_swing_hbr3_hbr2' defined but not used [-Wunused-const-variable=]
76 | static u8 const vm_voltage_swing_hbr3_hbr2[4][4] = {
|                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:69:17: warning: 'vm_pre_emphasis_hbr3_hbr2' defined but not used [-Wunused-const-variable=]
69 | static u8 const vm_pre_emphasis_hbr3_hbr2[4][4] = {
|                 ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:62:17: warning: 'vm_voltage_swing' defined but not used [-Wunused-const-variable=]
62 | static u8 const vm_voltage_swing[4][4] = {
|                 ^~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_catalog.c:54:17: warning: 'vm_pre_emphasis' defined but not used [-Wunused-const-variable=]
54 | static u8 const vm_pre_emphasis[4][4] = {
|                 ^~~~~~~~~~~~~~~
--
drivers/gpu/drm/msm/dp/dp_ctrl.c: In function '_tu_param_compare':
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:254:13: warning: variable 'b_frac' set but not used [-Wunused-but-set-variable]
254 |  u32 b_int, b_frac, b_sign;
|             ^~~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:254:6: warning: variable 'b_int' set but not used [-Wunused-but-set-variable]
254 |  u32 b_int, b_frac, b_sign;
|      ^~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:253:13: warning: variable 'a_frac' set but not used [-Wunused-but-set-variable]
253 |  u32 a_int, a_frac, a_sign;
|             ^~~~~~
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:253:6: warning: variable 'a_int' set but not used [-Wunused-but-set-variable]
253 |  u32 a_int, a_frac, a_sign;
|      ^~~~~
drivers/gpu/drm/msm/dp/dp_ctrl.c: In function 'dp_panel_update_tu_timings':
>> drivers/gpu/drm/msm/dp/dp_ctrl.c:301:6: warning: variable 'overhead_dsc' set but not used [-Wunused-but-set-variable]
301 |  s64 overhead_dsc;
|      ^~~~~~~~~~~~
--
drivers/gpu/drm/msm/dp/dp_link.c: In function 'dp_link_parse_phy_test_params':
drivers/gpu/drm/msm/dp/dp_link.c:576:47: error: 'DP_PHY_TEST_PATTERN' undeclared (first use in this function); did you mean 'DP_NO_TEST_PATTERN'?
576 |  rlen = drm_dp_dpcd_readb(link->aux->drm_aux, DP_PHY_TEST_PATTERN,
|                                               ^~~~~~~~~~~~~~~~~~~
|                                               DP_NO_TEST_PATTERN
drivers/gpu/drm/msm/dp/dp_link.c:576:47: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/msm/dp/dp_link.c: In function 'dp_link_adjust_levels':
>> drivers/gpu/drm/msm/dp/dp_link.c:1106:26: warning: variable 'link' set but not used [-Wunused-but-set-variable]
1106 |  struct dp_link_private *link;
|                          ^~~~
--
drivers/gpu/drm/msm/dp/dp_panel.c: In function 'dp_panel_read_dpcd':
>> drivers/gpu/drm/msm/dp/dp_panel.c:39:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
39 |  if (rlen < 0) {
|           ^
drivers/gpu/drm/msm/dp/dp_panel.c: At top level:
>> drivers/gpu/drm/msm/dp/dp_panel.c:283:4: warning: no previous prototype for 'dp_panel_get_edid_checksum' [-Wmissing-prototypes]
283 | u8 dp_panel_get_edid_checksum(struct edid *edid)
|    ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/msm/dp/dp_panel.c: In function 'dp_panel_put':
>> drivers/gpu/drm/msm/dp/dp_panel.c:482:27: warning: variable 'panel' set but not used [-Wunused-but-set-variable]
482 |  struct dp_panel_private *panel;
|                           ^~~~~
--
drivers/gpu/drm/msm/dp/dp_parser.c: In function 'dp_parser_init_clk_data':
>> drivers/gpu/drm/msm/dp/dp_parser.c:251:26: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
251 |  int num_clk = 0, i = 0, rc = 0;
|                          ^~
--
drivers/gpu/drm/msm/dp/dp_power.c: In function 'dp_power_clk_enable':
>> drivers/gpu/drm/msm/dp/dp_power.c:172:27: warning: variable 'mp' set but not used [-Wunused-but-set-variable]
172 |  struct dss_module_power *mp;
|                           ^~

vim +35 drivers/gpu/drm/msm/dp/dp_aux.c

    34	
  > 35	static const char * const dp_aux_get_error(u32 aux_error)
    36	{
    37		switch (aux_error) {
    38		case DP_AUX_ERR_NONE:
    39			return DP_AUX_ENUM_STR(DP_AUX_ERR_NONE);
    40		case DP_AUX_ERR_ADDR:
    41			return DP_AUX_ENUM_STR(DP_AUX_ERR_ADDR);
    42		case DP_AUX_ERR_TOUT:
    43			return DP_AUX_ENUM_STR(DP_AUX_ERR_TOUT);
    44		case DP_AUX_ERR_NACK:
    45			return DP_AUX_ENUM_STR(DP_AUX_ERR_NACK);
    46		case DP_AUX_ERR_DEFER:
    47			return DP_AUX_ENUM_STR(DP_AUX_ERR_DEFER);
    48		case DP_AUX_ERR_NACK_DEFER:
    49			return DP_AUX_ENUM_STR(DP_AUX_ERR_NACK_DEFER);
    50		default:
    51			return "unknown";
    52		}
    53	}
    54	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 73988 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200609/c453df45/attachment-0001.gz>


More information about the dri-devel mailing list