[PATCH] drm/omap: force runtime PM suspend on system suspend

Tony Lindgren tony at atomide.com
Tue Jun 9 15:12:32 UTC 2020


* Tomi Valkeinen <tomi.valkeinen at ti.com> [200609 10:33]:
> Use suspend_late and resume_early callbacks in DSS submodules to force
> runtime PM suspend and resume.
> 
> We use suspend_late callback so that omapdrm's system suspend callback
> is called first, as that will disable all the display outputs after
> which it's safe to force DSS into suspend.

I think we can avoid the pm_runtime_force use if we have omapdrm
implement both .suspend and .suspend_late. In that case suspend would
only disable the display outputs, then suspend_late would take care
of switching off the lights and release the last PM runtime count
after the children are done suspending.

Looks like we have already something similar done for i915_drv.c, so
it should be doable. Maybe the disconnect can be done in .prepare and
then .suspend_late is not even needed?

And I think at that point the children can just use the standard
UNIVERSAL_DEV_PM_OPS without pm_runtime_force usage hopefully :)

Regards,

Tony


More information about the dri-devel mailing list