[PATCH] drm/msm: call drm_mode_config_reset before drm_dev_register

[Rob Clark]

On Tue, Jun 9, 2020 at 5:47 PM Abhinav Kumar <abhinavk at codeaurora.org> wrote:
>
> As per the documentation of drm_dev_register, all drivers should
> call drm_dev_register after all the initialization is completed.
> This also means that drm_mode_config_reset should be done before
> drm_dev_register.
>
> Change the sequence to align with this documentation.
>
> Signed-off-by: Abhinav Kumar <abhinavk at codeaurora.org>

I assume this is just a cleanup you noticed, and not fixing a bug you
are hitting (in which case I'll pick it up next merge window, rather
than -fixes)

Reviewed-by: Rob Clark <robdclark at gmail.com>

> ---
>  drivers/gpu/drm/msm/msm_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 29295dee2a2e..9e77cc7f1fa4 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -538,12 +538,12 @@ static int msm_drm_init(struct device *dev, struct drm_driver *drv)
>                 }
>         }
>
> +       drm_mode_config_reset(ddev);
> +
>         ret = drm_dev_register(ddev, 0);
>         if (ret)
>                 goto err_msm_uninit;
>
> -       drm_mode_config_reset(ddev);
> -
>  #ifdef CONFIG_DRM_FBDEV_EMULATION
>         if (kms && fbdev)
>                 priv->fbdev = msm_fbdev_init(ddev);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>