[PATCH 2/8] drm/amdgpu: Use __drm_atomic_helper_crtc_reset

Alex Deucher alexdeucher at gmail.com
Fri Jun 12 17:41:17 UTC 2020


On Fri, Jun 12, 2020 at 1:24 PM Harry Wentland <hwentlan at amd.com> wrote:
>
> On 2020-06-12 12:00 p.m., Daniel Vetter wrote:
> > Now also comes with the added benefit of doing a drm_crtc_vblank_off(),
> > which means vblank state isn't ill-defined and fail-y at driver load
> > before the first modeset on each crtc.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > Cc: Alex Deucher <alexander.deucher at amd.com>
> > Cc: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
> > Cc: Harry Wentland <harry.wentland at amd.com>
> > Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> > Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
> > Cc: Roman Li <roman.li at amd.com>
> > Cc: Mikita Lipski <mikita.lipski at amd.com>
> > Cc: Stylon Wang <stylon.wang at amd.com>
>
> Reviewed-by: Harry Wentland <harry.wentland at amd.com>
>

Daniel, do you want to take the whole series, or should I pull this in
through my tree?  Either way works for me.  Thanks for the patch!

Alex

> Harry
>
> > ---
> >  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 68a73065b516..36d605a6eb16 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -4594,9 +4594,7 @@ static void dm_crtc_reset_state(struct drm_crtc *crtc)
> >       if (WARN_ON(!state))
> >               return;
> >
> > -     crtc->state = &state->base;
> > -     crtc->state->crtc = crtc;
> > -
> > +     __drm_atomic_helper_crtc_reset(crtc, &state->base);
> >  }
> >
> >  static struct drm_crtc_state *
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel


More information about the dri-devel mailing list