[PATCH] drm/mxsfb: miss err handle in probe
Bernard Zhao
bernard at vivo.com
Thu Jun 11 12:23:11 UTC 2020
There are three err return values in drm_fbdev_generic_setup.
In mxsfb_probe we called this function, but didn`t handle the
return value, this change is to add err handle, maybe make code
a bit more readable.
Signed-off-by: Bernard Zhao <bernard at vivo.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 497cf443a9af..a45f3b85f725 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -415,7 +415,9 @@ static int mxsfb_probe(struct platform_device *pdev)
if (ret)
goto err_unload;
- drm_fbdev_generic_setup(drm, 32);
+ ret = drm_fbdev_generic_setup(drm, 32);
+ if (ret)
+ goto err_unload;
return 0;
--
2.17.1
More information about the dri-devel
mailing list