[PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync

Andy Shevchenko andy.shevchenko at gmail.com
Sun Jun 14 09:48:06 UTC 2020


On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost
<navid.emamdoost at gmail.com> wrote:

...

> +               if (ret < 0) {

> +                       pm_runtime_put(gpu->dev);

Please, in all your patches fix this to be _put_noidle(). We wouldn't
bear the flag day of fixing these parts again.
Yes, I know that *now* behaviour is the same, but calling put here is
slightly inconsistent.

...

> +               pm_runtime_put(gpu->dev);

-- 
With Best Regards,
Andy Shevchenko


More information about the dri-devel mailing list