[PATCH] drm/mgag200: Don't set <rammapen> in MISC

Emil Velikov emil.l.velikov at gmail.com
Tue Jun 16 15:14:27 UTC 2020


Hi Thomas,

On Tue, 16 Jun 2020 at 15:26, Thomas Zimmermann <tzimmermann at suse.de> wrote:
>
> The original modesetting code set MISC to 0x2d, which is <hpgoddev>,
> <clksel> and <ioaddsel>
>
> With the conversion to atomic modesetting, <rammapen> accidentally
> got enabled as well. Revert this change and initialize MISC with a
> constant value of <hgoddev> and <ioaddsel>. The <clksel> bits are set
> in mga_crtc_set_plls(), sync flags are set in mgag200_set_mode_regs().
>

Let's keep the remove (restoring original functionality) and rename
(cosmetics) separate patches. The read has also disappeared, which
should be safe although might be better on it's own.

Thanks
Emil


More information about the dri-devel mailing list