[PATCH] drm/vblank: Fix documentation of VBLANK timestamp helper
Daniel Vetter
daniel at ffwll.ch
Tue Mar 3 08:37:14 UTC 2020
On Tue, Mar 03, 2020 at 08:31:35AM +0100, Thomas Zimmermann wrote:
> Per-CRTC VBLANK information used to be addressed by device and pipe
> index. A call drm_crtc_vblank_helper_get_vblank_timestamp_internal()
> receives a pointer to the CRTC instead. Fix the documentation.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Reported-by: Daniel Vetter <daniel at ffwll.ch>
> Fixes: f1e2b6371c12 ("drm: Add get_scanout_position() to struct drm_crtc_helper_funcs")
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> Cc: dri-devel at lists.freedesktop.org
Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
> drivers/gpu/drm/drm_vblank.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
> index 47fc4339ec7f..da7b0b0c1090 100644
> --- a/drivers/gpu/drm/drm_vblank.c
> +++ b/drivers/gpu/drm/drm_vblank.c
> @@ -592,8 +592,7 @@ EXPORT_SYMBOL(drm_calc_timestamping_constants);
> /**
> * drm_crtc_vblank_helper_get_vblank_timestamp_internal - precise vblank
> * timestamp helper
> - * @dev: DRM device
> - * @pipe: index of CRTC whose vblank timestamp to retrieve
> + * @crtc: CRTC whose vblank timestamp to retrieve
> * @max_error: Desired maximum allowable error in timestamps (nanosecs)
> * On return contains true maximum error of timestamp
> * @vblank_time: Pointer to time which should receive the timestamp
> --
> 2.25.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
More information about the dri-devel
mailing list