[PATCH 0/5] Cleanup drm_dp_mst_topology_cbs hooks
Lyude Paul
lyude at redhat.com
Mon Mar 9 20:27:39 UTC 2020
On Sat, 2020-03-07 at 14:00 +0530, Pankaj Bharadiya wrote:
> drm_dp_mst_topology_mgr_cbs.register_connector callbacks are identical
> amongst every driver and don't do anything other than calling
> drm_connector_register().
> drm_dp_mst_topology_mgr_cbs.destroy_connector callbacks are identical
> amongst every driver and don't do anything other than cleaning up the
> connector((drm_connector_unregister()/drm_connector_put())) except for
> amdgpu_dm driver where some amdgpu_dm specific code in there.
Yeah that amdgpu destruction code kinda stinks a little bit :\. I think we can
just drop some of it and move the rest into their connector destruction
callbacks.
For the whole series:
Reviewed-by: Lyude Paul <lyude at redhat.com>
I'm going to go ahead and let the maintainers know I'm going to push this
(since there's some minor changes here outside of drm-misc), and push this to
drm-misc-next. Then I'll go and write some patches to remove the leftover amd
bits and drop the callback for good (I'll cc it to you as well).
>
> This series aims to cleaup these drm_dp_mst_topology_mgr_cbs hooks.
>
> Pankaj Bharadiya (5):
> drm: Register connector instead of calling register_connector callback
> drm: Remove dp mst register connector callbacks
> drm/dp_mst: Remove register_connector callback
> drm: Add drm_dp_destroy_connector helper and use it
> drm: Remove drm dp mst destroy_connector callbacks
>
> .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 ------
> drivers/gpu/drm/drm_dp_mst_topology.c | 18 +++++++++++++++---
> drivers/gpu/drm/i915/display/intel_dp_mst.c | 16 ----------------
> drivers/gpu/drm/nouveau/dispnv50/disp.c | 19 -------------------
> drivers/gpu/drm/radeon/radeon_dp_mst.c | 17 -----------------
> include/drm/drm_dp_mst_helper.h | 1 -
> 6 files changed, 15 insertions(+), 62 deletions(-)
>
--
Cheers,
Lyude Paul (she/her)
Associate Software Engineer at Red Hat
More information about the dri-devel
mailing list