[PATCH] drm/hisilicon: Drop unused #include

[Daniel Vetter]

On Wed, Mar 18, 2020 at 01:09:37PM +0200, Laurent Pinchart wrote:
> Hi Daniel,
> 
> On Wed, Mar 18, 2020 at 08:31:22AM +0100, Daniel Vetter wrote:
> > drm_encoder_slave is really not something anyone should be using,
> > the last real user is only nouveau.
> 
> Fully agreed.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> Is there any plan to convert nouveau to drm_bridge ?

Apparently the only user in nouveau is for nv17 cards - after that the tv
encoder is integrated. This is so old and cards rare (quick irc chat among
the usual suspects suggested there might be none available anymore) that a
quick rm might be the better solution than trying to convert this over to
drm_bridge :-)

We should definitely look into pushing the drm_encoder_slave into
drm/nouveau, and maybe delete drm/i2c. The other two things in there kinda
don't belong - one isn't even a drm driver!

Cheers, Daniel

> 
> > Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Boris Brezillon <boris.brezillon at collabora.com>
> > Cc: Sam Ravnborg <sam at ravnborg.org>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Tomi Valkeinen <tomi.valkeinen at ti.com>
> > Cc: Allison Randal <allison at lohutok.net>
> > Cc: Thomas Gleixner <tglx at linutronix.de>
> > Cc: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> >  drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > index f31068d74b18..d399c1077242 100644
> > --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c
> > @@ -20,7 +20,6 @@
> >  #include <drm/drm_atomic_helper.h>
> >  #include <drm/drm_bridge.h>
> >  #include <drm/drm_device.h>
> > -#include <drm/drm_encoder_slave.h>
> >  #include <drm/drm_mipi_dsi.h>
> >  #include <drm/drm_of.h>
> >  #include <drm/drm_print.h>
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch