[PATCH v2] drm/todo: Add todo to make i915 WARN* calls drm device specific

Pankaj Bharadiya pankaj.laxminarayan.bharadiya at intel.com
Mon Mar 30 19:32:08 UTC 2020


With below commit, we have new struct drm_device based WARN* macros,
which include device specific information in the backtrace.

commit dc1a73e50f9c63d4dd928df538082200467dc4b1
Author: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>
Date:   Wed Jan 15 09:14:45 2020 +0530

    drm/print: introduce new struct drm_device based WARN* macros

Majority of the i915 WARN* are already converted to use struct
drm_device specific drm_WARN* calls. Add new todo entry for
pending conversions.

Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>
---
changes since v1:
* Remove accidentally added unrelated change (Sam)
* Update commit description by adding space after full stop (Sam)
 
 Documentation/gpu/todo.rst | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 37a3a023c114..d009a84384b3 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -575,6 +575,18 @@ See drivers/gpu/drm/amd/display/TODO for tasks.
 
 Contact: Harry Wentland, Alex Deucher
 
+Make i915 WARN* Calls struct drm_device Specific
+------------------------------------------------
+
+struct drm_device specific drm_WARN* macros include device information in the
+backtrace, so we know what device the warnings originate from. Convert all the
+calls of WARN* with drm_WARN* calls in i915. While at it, remove WARN* which
+are not truly valid.
+
+Contact: Jani Nikula
+
+Level: Starter
+
 Bootsplash
 ==========
 
-- 
2.23.0



More information about the dri-devel mailing list