[PATCH V1 00/10] Remove duplicated kmap code
ira.weiny at intel.com
Fri May 1 17:18:28 UTC 2020
On Fri, May 01, 2020 at 01:54:56AM -0700, Christoph Hellwig wrote:
> In addition to the work already it the series, it seems like
> LAST_PKMAP_MASK, PKMAP_ADDR and PKMAP_NR can also be consolidated
> to common code.
Agreed, I mentioned in the cover letter there are similarities...
> Also kmap_atomic_high_prot / kmap_atomic_pfn could move into common
> code, maybe keyed off a symbol selected by the actual users that
> need it. It also seems like it doesn't actually ever need to be
... but these are not as readily obvious, at least to me. I do see a pattern
but the differences seemed subtle enough that it would take a while to ensure
correctness. So I'd like to see this series go in and build on it.
> This in turn would lead to being able to allow io_mapping_map_atomic_wc
> on all architectures, which might make nouveau and qxl happy, but maybe
> that can be left for another series.
I agree, that this should be follow on patches. I still need to fix the
bisect-ability and I don't want to bog down 0-day with a longer series.
Thanks for the review!
More information about the dri-devel