[PATCH 07/36] drm/gma500: Use lockless gem BO free callback

Thomas Zimmermann tzimmermann at suse.de
Thu May 7 17:16:10 UTC 2020


Hi

Am 07.05.20 um 17:07 schrieb Emil Velikov:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> No dev->struct_mutex anywhere to be seen.
> 
> Cc: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  drivers/gpu/drm/gma500/psb_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
> index 2411eb9827b8..34b4aae9a15e 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.c
> +++ b/drivers/gpu/drm/gma500/psb_drv.c
> @@ -507,7 +507,7 @@ static struct drm_driver driver = {
>  	.irq_uninstall = psb_irq_uninstall,
>  	.irq_handler = psb_irq_handler,
>  
> -	.gem_free_object = psb_gem_free_object,
> +	.gem_free_object_unlocked = psb_gem_free_object,

I'd also rename the function to psb_gem_free_object_unlocked(). In any case

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

>  	.gem_vm_ops = &psb_gem_vm_ops,
>  
>  	.dumb_create = psb_gem_dumb_create,
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200507/2ef3598a/attachment.sig>


More information about the dri-devel mailing list