[PATCH] dma-buf: fix use-after-free in dmabuffs_dname

Greg KH gregkh at linuxfoundation.org
Tue May 12 08:45:34 UTC 2020

On Tue, May 12, 2020 at 10:43:18AM +0530, Charan Teja Kalla wrote:
> > Ok, but watch out, now you have 2 different reference counts for the
> > same structure.  Keeping them coordinated is almost always an impossible
> > task so you need to only rely on one.  If you can't use the file api,
> > just drop all of the reference counting logic in there and only use the
> > kref one.
> I feel that changing the refcount logic now to dma-buf objects involve
> changes in
> the core dma-buf framework. NO? Instead, how about passing the user passed
> name directly
> in the ->d_fsdata inplace of dmabuf object? Because we just need user passed
> name in the
> dmabuffs_dname(). With this we can avoid the need for extra refcount on
> dmabuf.

Odd formatting :(

> Posted patch-V2: https://lkml.org/lkml/2020/5/8/158

Please just post links to lore.kernel.org, we have no control over
lkml.org at all.

I'll go review that patch now...

greg k-h

More information about the dri-devel mailing list