[PATCH v2 15/16] backlight: make of_find_backlight_by_node() static
kbuild test robot
lkp at intel.com
Sun May 17 20:53:59 UTC 2020
Hi Sam,
I love your patch! Yet something to improve:
[auto build test ERROR on tegra-drm/drm/tegra/for-next]
[also build test ERROR on pwm/for-next linus/master v5.7-rc5]
[cannot apply to backlight/for-backlight-next next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Sam-Ravnborg/backlight-updates/20200518-030516
base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp at intel.com>
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c: In function 'dsicm_probe_of':
>> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:1221:21: error: implicit declaration of function 'of_find_backlight_by_node'; did you mean 'of_find_device_by_node'? [-Werror=implicit-function-declaration]
1221 | ddata->extbldev = of_find_backlight_by_node(backlight);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| of_find_device_by_node
>> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c:1221:19: warning: assignment to 'struct backlight_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
1221 | ddata->extbldev = of_find_backlight_by_node(backlight);
| ^
cc1: some warnings being treated as errors
vim +1221 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
dbc23840b4d70f drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-05-24 1162
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1163 static int dsicm_probe_of(struct platform_device *pdev)
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1164 {
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1165 struct device_node *node = pdev->dev.of_node;
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1166 struct device_node *backlight;
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1167 struct panel_drv_data *ddata = platform_get_drvdata(pdev);
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1168 struct display_timing timing;
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1169 int err;
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1170
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1171 ddata->reset_gpio = devm_gpiod_get(&pdev->dev, "reset", GPIOD_OUT_LOW);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1172 if (IS_ERR(ddata->reset_gpio)) {
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1173 err = PTR_ERR(ddata->reset_gpio);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1174 dev_err(&pdev->dev, "reset gpio request failed: %d", err);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1175 return err;
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1176 }
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1177
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1178 ddata->ext_te_gpio = devm_gpiod_get_optional(&pdev->dev, "te",
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1179 GPIOD_IN);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1180 if (IS_ERR(ddata->ext_te_gpio)) {
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1181 err = PTR_ERR(ddata->ext_te_gpio);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1182 dev_err(&pdev->dev, "TE gpio request failed: %d", err);
9231abd32876db drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1183 return err;
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1184 }
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1185
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1186 err = of_get_display_timing(node, "panel-timing", &timing);
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1187 if (!err) {
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1188 videomode_from_timing(&timing, &ddata->vm);
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1189 if (!ddata->vm.pixelclock)
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1190 ddata->vm.pixelclock =
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1191 ddata->vm.hactive * ddata->vm.vactive * 60;
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1192 } else {
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1193 dev_warn(&pdev->dev,
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1194 "failed to get video timing, using defaults\n");
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1195 }
e128310ddd379b drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Tony Lindgren 2017-07-24 1196
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1197 ddata->width_mm = 0;
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1198 of_property_read_u32(node, "width-mm", &ddata->width_mm);
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1199
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1200 ddata->height_mm = 0;
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1201 of_property_read_u32(node, "height-mm", &ddata->height_mm);
d95c5a0e0154af drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1202
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1203 ddata->vpnl = devm_regulator_get_optional(&pdev->dev, "vpnl");
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1204 if (IS_ERR(ddata->vpnl)) {
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1205 err = PTR_ERR(ddata->vpnl);
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1206 if (err == -EPROBE_DEFER)
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1207 return err;
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1208 ddata->vpnl = NULL;
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1209 }
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1210
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1211 ddata->vddi = devm_regulator_get_optional(&pdev->dev, "vddi");
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1212 if (IS_ERR(ddata->vddi)) {
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1213 err = PTR_ERR(ddata->vddi);
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1214 if (err == -EPROBE_DEFER)
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1215 return err;
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1216 ddata->vddi = NULL;
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1217 }
82fa10d46be9d1 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1218
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1219 backlight = of_parse_phandle(node, "backlight", 0);
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1220 if (backlight) {
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 @1221 ddata->extbldev = of_find_backlight_by_node(backlight);
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1222 of_node_put(backlight);
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1223
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1224 if (!ddata->extbldev)
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1225 return -EPROBE_DEFER;
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1226 } else {
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1227 /* assume native backlight support */
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1228 ddata->use_dsi_backlight = true;
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1229 }
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1230
a44e552a1f4371 drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c Sebastian Reichel 2017-07-24 1231 /* TODO: ulps */
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1232
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1233 return 0;
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1234 }
cdeeaca2a11d31 drivers/video/omap2/displays-new/panel-dsi-cm.c Tomi Valkeinen 2013-07-30 1235
:::::: The code at line 1221 was first introduced by commit
:::::: a44e552a1f4371a02473da5448add5320a01f5ff drm/omap: panel-dsi-cm: add external backlight support
:::::: TO: Sebastian Reichel <sebastian.reichel at collabora.co.uk>
:::::: CC: Tomi Valkeinen <tomi.valkeinen at ti.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 73995 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200518/0ed0f42d/attachment-0001.gz>
More information about the dri-devel
mailing list