[PATCH v2 1/2] fbdev: annotate rivafb/nvidiafb as obsolete

[kbuild test robot]

Hi Emil,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on powerpc/next]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Emil-Velikov/fbdev-annotate-rivafb-nvidiafb-as-obsolete/20200518-060957
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp at intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_init':
>> drivers/video/fbdev/riva/fbdev.c:2167:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^~~~
--
drivers/video/fbdev/nvidia/nvidia.c: In function 'nvidiafb_init':
>> drivers/video/fbdev/nvidia/nvidia.c:1519:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
char *option = NULL;
^~~~

vim +2167 drivers/video/fbdev/riva/fbdev.c

^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2152  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2153  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2154  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2155  /* ------------------------------------------------------------------------- *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2156   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2157   * modularization
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2158   *
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2159   * ------------------------------------------------------------------------- */
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2160  
48c68c4f1b5424 drivers/video/riva/fbdev.c       Greg Kroah-Hartman 2012-12-21  2161  static int rivafb_init(void)
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2162  {
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2163  	pr_warn("Legacy rivafb framebuffer driver will be removed in 2022\n"
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2164  		"Please switch to nouveau DRM driver\n");
f59e794dc40501 drivers/video/fbdev/riva/fbdev.c Emil Velikov       2020-05-17  2165  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2166  #ifndef MODULE
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16 @2167  	char *option = NULL;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2168  
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2169  	if (fb_get_options("rivafb", &option))
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2170  		return -ENODEV;
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2171  	rivafb_setup(option);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2172  #endif
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2173  	return pci_register_driver(&rivafb_driver);
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2174  }
^1da177e4c3f41 drivers/video/riva/fbdev.c       Linus Torvalds     2005-04-16  2175  

:::::: The code at line 2167 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds at ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds at ppc970.osdl.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 72337 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200518/1bb50af1/attachment-0001.gz>