[PATCH v2] drm/debugfs: fix plain echo to connector "force" attribute

Emil Velikov emil.l.velikov at gmail.com
Mon May 18 10:39:08 UTC 2020


On Mon, 18 May 2020 at 10:22, Jani Nikula <jani.nikula at linux.intel.com> wrote:
>
> On Sun, 17 May 2020, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > On Thu, 17 Aug 2017 at 12:34, Jani Nikula <jani.nikula at linux.intel.com> wrote:
> >>
> >> On Thu, 17 Aug 2017, Michael Tretter <m.tretter at pengutronix.de> wrote:
> >> > Using plain echo to set the "force" connector attribute fails with
> >> > -EINVAL, because echo appends a newline to the output.
> >> >
> >> > Replace strcmp with sysfs_streq to also accept strings that end with a
> >> > newline.
> >> >
> >> > v2: use sysfs_streq instead of stripping trailing whitespace
> >> >
> >> > Signed-off-by: Michael Tretter <m.tretter at pengutronix.de>
> >>
> >> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> >>
> > Seems like this fell through the cracks. Pushed to drm-misc-next.
>
> From 2017? How'd you find it? :o
>
> My bad, thanks.
>
A colleague mentioned about their experiences with \n, so I remembered
seeing something.
>From a quick grep, we have have handful of other cases mostly in
amdgpu and radeon. Will see it I can prep a patch later on today.

-Emil


More information about the dri-devel mailing list