[PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

Emil Velikov emil.l.velikov at gmail.com
Mon May 18 13:19:57 UTC 2020


On Mon, 18 May 2020 at 13:48, Bartlomiej Zolnierkiewicz
<b.zolnierkie at samsung.com> wrote:
>
>
> On 5/18/20 1:19 PM, Emil Velikov wrote:
> > Hi Michael,
> >
> > On Mon, 18 May 2020 at 08:30, Michael Ellerman <mpe at ellerman.id.au> wrote:
> >>
> >> Emil Velikov <emil.l.velikov at gmail.com> writes:
> >>> As mentioned in earlier commit, the riva and nvidia fbdev drivers have
> >>> seen no love over the years, are short on features and overall below par
> >>>
> >>> Users are encouraged to switch to the nouveau drm driver instead.
> >>>
> >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej)
> >>>
> >>> Cc: Antonino Daplas <adaplas at gmail.com>
> >>> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> >>> Cc: linux-fbdev at vger.kernel.org
> >>> Cc: dri-devel at lists.freedesktop.org
> >>> Cc: Michael Ellerman <mpe at ellerman.id.au>
> >>> Cc: Benjamin Herrenschmidt <benh at kernel.crashing.org>
> >>> Cc: Paul Mackerras <paulus at samba.org>
> >>> Cc: linuxppc-dev at lists.ozlabs.org
> >>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> >>> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch> (v1)
> >>> ---
> >>> Hi all unless, there are objections I would prefer to merge this via
> >>> the drm tree.
> >>
> >> Have you tested that the resulting kernels work on the relevant
> >> hardware?
> >>
> > Sadly, no I haven't. I'm updating the defconfigs as requested by the
> > fbdev maintainer.
>
> I've just noticed that v1 (patch #1/1) & v2 (patch #1/2) lack
> Cc: to powerpc Maintainers so they cannot see the context of
> changes in this patch.
>
Haven't see any instances of fbdev/drm patches being Cc to arch/ developers.
As such I made sure the commit message illustrates 1/2 as clearly as possible.

> Also you've proposed v1 yourself and it has already contained
> modifications to defconfigs (removal of setting the config
> options for the old drivers) in addition to marking the old
> drivers as BROKEN.
>
> It now turns out that v1 has also never been tested. :(
>
> Please don't submit untested patches without marking them
> as such.
>
Does x86 box with nv34 GPU count as testing? I suspect not :-(
It was been using nouveau ever since I bought it 15+ years ago.

Will be more careful in the future.

-Emil


More information about the dri-devel mailing list