[PATCH 2/2] drm: add docs for standard CRTC properties
Simon Ser
contact at emersion.fr
Mon May 18 14:22:47 UTC 2020
This patch adds docs for the ACTIVE and MODE_ID CRTC properties.
Signed-off-by: Simon Ser <contact at emersion.fr>
Cc: Daniel Vetter <daniel.vetter at intel.com>
Cc: Ville Syrjala <ville.syrjala at linux.intel.com>
Cc: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
Cc: Michel Dänzer <michel at daenzer.net>
---
Let me know if you think of other things to add.
Should we refer to ALLOW_MODESET in the MODE_ID docs?
Documentation/gpu/drm-kms.rst | 5 +++++
drivers/gpu/drm/drm_crtc.c | 16 ++++++++++++++++
2 files changed, 21 insertions(+)
diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst
index 397314d08f77..4289b7205696 100644
--- a/Documentation/gpu/drm-kms.rst
+++ b/Documentation/gpu/drm-kms.rst
@@ -460,6 +460,11 @@ HDMI Specific Connector Properties
.. kernel-doc:: drivers/gpu/drm/drm_connector.c
:doc: HDMI connector properties
+Standard CRTC Properties
+
+.. kernel-doc:: drivers/gpu/drm/drm_crtc.c
+ :doc: standard CRTC properties
+
Plane Composition Properties
----------------------------
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 4936e1080e41..c28e662c1e93 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -204,6 +204,22 @@ struct dma_fence *drm_crtc_create_fence(struct drm_crtc *crtc)
return fence;
}
+/**
+ * DOC: standard CRTC properties
+ *
+ * DRM CRTCs have a few standardized properties:
+ *
+ * ACTIVE:
+ * Atomic property for setting the power state of the CRTC. When set to 1 the
+ * CRTC will actively display content. When set to 0 the CRTC will be powered
+ * off. There is no expectation that user-space will reset CRTC resources like
+ * the mode and planes when setting ACTIVE to 0.
+ * MODE_ID:
+ * Atomic property for setting the CRTC display timings. The value is the ID
+ * of a blob containing the DRM mode info. To disable the CRTC, user-space
+ * must set this property to 0.
+ */
+
/**
* drm_crtc_init_with_planes - Initialise a new CRTC object with
* specified primary and cursor planes.
--
2.26.2
More information about the dri-devel
mailing list