[PATCH 1/4] drm: Include internal header for managed function declarations

Daniel Vetter daniel at ffwll.ch
Mon May 18 14:42:21 UTC 2020


On Sat, May 16, 2020 at 10:23:27PM +0100, Chris Wilson wrote:
> drivers/gpu/drm/drm_managed.c:61:6: warning: symbol 'drm_managed_release' was not declared. Should it be static?
>   CC      drivers/gpu/drm/drm_managed.o
> drivers/gpu/drm/drm_managed.c:61:6: warning: no previous prototype for ‘drm_managed_release’ [-Wmissing-prototypes]
>  void drm_managed_release(struct drm_device *dev)

Drat! Thanks for fixing.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

> 
> Fixes: c6603c740e0e ("drm: add managed resources tied to drm_device")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Daniel Vetter <daniel at ffwll.ch>
> ---
>  drivers/gpu/drm/drm_managed.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_managed.c b/drivers/gpu/drm/drm_managed.c
> index 9cebfe370a65..1e1356560c2e 100644
> --- a/drivers/gpu/drm/drm_managed.c
> +++ b/drivers/gpu/drm/drm_managed.c
> @@ -14,6 +14,8 @@
>  #include <drm/drm_device.h>
>  #include <drm/drm_print.h>
>  
> +#include "drm_internal.h"
> +
>  /**
>   * DOC: managed resources
>   *
> -- 
> 2.20.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the dri-devel mailing list