[PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

[Deucher, Alexander]

[AMD Public Use]

Yes, please drop this patch for stable.

Alex
________________________________
From: Marek Olšák <maraeo at gmail.com>
Sent: Monday, May 18, 2020 6:35 PM
To: Sasha Levin <sashal at kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel at vger.kernel.org>; stable at vger.kernel.org <stable at vger.kernel.org>; Pelloux-prayer, Pierre-eric <Pierre-eric.Pelloux-prayer at amd.com>; Olsak, Marek <Marek.Olsak at amd.com>; amd-gfx mailing list <amd-gfx at lists.freedesktop.org>; dri-devel <dri-devel at lists.freedesktop.org>; Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>
Subject: Re: [PATCH AUTOSEL 5.6 33/50] drm/amdgpu: bump version for invalidate L2 before SDMA IBs

Hi Sasha,

I disagree with this. Bumping the driver version will have implications on other new features, because it's like an ABI barrier exposing new functionality.

Marek

On Thu, May 7, 2020 at 10:28 AM Sasha Levin <sashal at kernel.org<mailto:sashal at kernel.org>> wrote:
From: Marek Olšák <marek.olsak at amd.com<mailto:marek.olsak at amd.com>>

[ Upstream commit 9017a4897a20658f010bebea825262963c10afa6 ]

This fixes GPU hangs due to cache coherency issues.
Bump the driver version. Split out from the original patch.

Signed-off-by: Marek Olšák <marek.olsak at amd.com<mailto:marek.olsak at amd.com>>
Reviewed-by: Christian König <christian.koenig at amd.com<mailto:christian.koenig at amd.com>>
Tested-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com<mailto:pierre-eric.pelloux-prayer at amd.com>>
Signed-off-by: Alex Deucher <alexander.deucher at amd.com<mailto:alexander.deucher at amd.com>>
Signed-off-by: Sasha Levin <sashal at kernel.org<mailto:sashal at kernel.org>>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 42f4febe24c6d..8d45a2b662aeb 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -85,9 +85,10 @@
  * - 3.34.0 - Non-DC can flip correctly between buffers with different pitches
  * - 3.35.0 - Add drm_amdgpu_info_device::tcc_disabled_mask
  * - 3.36.0 - Allow reading more status registers on si/cik
+ * - 3.37.0 - L2 is invalidated before SDMA IBs, needed for correctness
  */
 #define KMS_DRIVER_MAJOR       3
-#define KMS_DRIVER_MINOR       36
+#define KMS_DRIVER_MINOR       37
 #define KMS_DRIVER_PATCHLEVEL  0

 int amdgpu_vram_limit = 0;
--
2.20.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
https://lists.freedesktop.org/mailman/listinfo/amd-gfx<https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7Calexander.deucher%40amd.com%7C2bb4939b162b4d66d57708d7fb7bd608%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637254381604715852&sdata=uJEI0CDUeUbUGUgnhnobpKygBueEGg6UqwgzkEtIsh8%3D&reserved=0>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20200519/6f2f84e3/attachment.htm>