[PATCH] drm/vblank: Fix -Wformat compile warnings on some arches

Sam Ravnborg sam at ravnborg.org
Sat May 23 06:54:12 UTC 2020


Hi Lyude.

> > > *dev, unsigned int pipe,
> > >  
> > >  	DRM_DEBUG_VBL("updating vblank count on crtc %u:"
> > >  		      " current=%llu, diff=%u, hw=%u hw_last=%u\n",
> > > -		      pipe, atomic64_read(&vblank->count), diff,
> > > +		      pipe, (unsigned long long)atomic64_read(&vblank->count),
> > > diff,
> > >  		      cur_vblank, vblank->last);
> > 
> > While touching this you could consider introducing drm_dbg_vbl().
> > An maybe as a follow-up patch replace all logging in this file with the drm_*
> > variants.
> 
> ok - no promises when I can actually get to this though, I've got a lot on my
> plate ATM

I wnet ahead and applied this patch (after fixing a too long line),
and then I updated the logging functions as suggested above.
I applied the patch to drm-misc-next.

Patches with updated logging coming.

	Sam


More information about the dri-devel mailing list