[PATCH v2 01/16] video: amba-clcd: use devm_of_find_backlight

Linus Walleij linus.walleij at linaro.org
Mon May 25 08:42:26 UTC 2020


On Mon, May 18, 2020 at 12:16 PM Sam Ravnborg <sam at ravnborg.org> wrote:
> Hi Linus.
>
> On Mon, May 18, 2020 at 10:10:12AM +0200, Linus Walleij wrote:
> > On Sun, May 17, 2020 at 9:01 PM Sam Ravnborg <sam at ravnborg.org> wrote:
> >
> > > Look up backlight device using devm_of_find_backlight().
> > > This simplifies the code and prevents us from hardcoding
> > > the node name in the driver.
> > >
> > > v2:
> > >   - Added Cc: Peter Ujfalusi
> > >
> > > Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> > > Cc: Russell King <linux at armlinux.org.uk>
> > > Cc: Sam Ravnborg <sam at ravnborg.org>
> > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> > > Cc: Peter Ujfalusi <peter.ujfalusi at ti.com>
> > > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > > Cc: Linus Walleij <linus.walleij at linaro.org>
> > > Cc: Jani Nikula <jani.nikula at intel.com>
> > > Cc: Douglas Anderson <dianders at chromium.org>
> >
> > Acked-by: Linus Walleij <linus.walleij at linaro.org>
> Thanks. I went ahead and applied this now, so we could kill
> the last user of of_find_backlight_by_node().
>
> I hope we can make of_find_backlight_by_node() static after the merge window
> so no new users appears.

For this driver (drivers/video/fbdev/amba-clcd.c) there are zero
users after the merge window (all users moved over to DRM) so
I plan to retire it completely.

Yours,
Linus Walleij


More information about the dri-devel mailing list