[PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush()

[Emil Velikov]

Hi all,

I realise this has landed, so a small FYI comment.

On Sat, 9 May 2020 at 15:16, Noralf Trønnes <noralf at tronnes.org> wrote:

> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect)
> +{
> +       if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)

Hmm cannot think of a good reason why anyone would call this with
!buffer || !buffer->fb?
Might be a good idea to WARN in those cases - otherwise the user is
given false sense to security.

Looking at the upcoming user (drm/gud) it already has both - so it's
perfectly safe.

-Emil