[PATCH v2 1/4] ARM: dts: dove: Make the DT compliant with the ti,tfp410 binding

[Laurent Pinchart]

Hi Rob,

On Thu, May 28, 2020 at 11:37:55AM -0600, Rob Herring wrote:
> On Thu, May 14, 2020 at 04:36:09PM +0200, Ricardo Cañuelo wrote:
> > Define a 'ports' node for 'dvi: video at 39' and use the proper naming for
> > the powerdown-gpios property to make it compliant with the ti,tfp410
> > binding.
> > 
> > This fills the minimum requirements to meet the binding requirements,
> > port endpoints are not defined.
> 
> Just make 'ports' optional. This isn't really any better unless you add 
> endpoints too.

I wonder how this is supposed to work though. The ti-tfp410 driver will
fail to probe if there's no endpoint. I'd rather already add a node for
the DVI connector and connect it to port at 1 of the TFP410.

> > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo at collabora.com>
> > ---
> >  arch/arm/boot/dts/dove-sbc-a510.dts | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/boot/dts/dove-sbc-a510.dts b/arch/arm/boot/dts/dove-sbc-a510.dts
> > index 2bb85a9b7614..32804c981625 100644
> > --- a/arch/arm/boot/dts/dove-sbc-a510.dts
> > +++ b/arch/arm/boot/dts/dove-sbc-a510.dts
> > @@ -132,7 +132,18 @@
> >  	dvi: video at 39 {
> >  		compatible = "ti,tfp410";
> >  		reg = <0x39>;
> > -		powerdown-gpio = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> > +		powerdown-gpios = <&gpio_ext 3 GPIO_ACTIVE_LOW>;
> > +
> > +		ports {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			port at 0 {
> > +				reg = <0>;
> > +			};
> > +			port at 1 {
> > +				reg = <1>;
> > +			};
> > +		};
> >  	};
> >  };
> >  

-- 
Regards,

Laurent Pinchart