[PATCH 6/6] drm/vc4: kms: Add functions to create the state objects

[Maxime Ripard]

On Fri, Oct 30, 2020 at 09:59:31AM +0100, Daniel Vetter wrote:
> On Thu, Oct 29, 2020 at 08:01:04PM +0100, Maxime Ripard wrote:
> > In order to make the vc4_kms_load code and error path a bit easier to
> > read and extend, add functions to create state objects, and use managed
> > actions to cleanup if needed.
> > 
> > Signed-off-by: Maxime Ripard <maxime at cerno.tech>
> 
> Nice. With an s/drmm_add_action/drmm_add_action_or_reset/ over the entire
> series:
> 
> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Applied with drmm_add_action_or_reset

> btw there's a series pending from imx people (Philip Zabel iirc) to add
> drmm support for modeset objects. I think that would really help clean up
> vc4. Or well make it slightly less buggy, since atm you're using
> devm_kzalloc, which strictly speaking, frees the memory too early.

I'll have a look, thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201102/1ba67848/attachment-0001.sig>