答复: [PATCH -next] drm/panfrost: Fix unused variable warning

Zouwei (Samuel) zou_wei at huawei.com
Mon Nov 2 11:54:43 UTC 2020


Hi Steve,
Sorry, I didn't notice the patch earlier.
Please ignore my patch.

-----邮件原件-----
发件人: Steven Price [mailto:steven.price at arm.com] 
发送时间: 2020年11月2日 17:29
收件人: Zouwei (Samuel) <zou_wei at huawei.com>; robh at kernel.org; tomeu.vizoso at collabora.com; alyssa.rosenzweig at collabora.com; airlied at linux.ie; daniel at ffwll.ch
抄送: dri-devel at lists.freedesktop.org; linux-kernel at vger.kernel.org
主题: Re: [PATCH -next] drm/panfrost: Fix unused variable warning

On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
> 
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
>    struct panfrost_job_slot *js = pfdev->js;
>                              ^~
> 
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zou Wei <zou_wei at huawei.com>

Boris posted an identical patch earlier:

https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com

Steve

> ---
>   drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>   
>   void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
>   {
> -	struct panfrost_device *pfdev = panfrost_priv->pfdev;
> -	struct panfrost_job_slot *js = pfdev->js;
>   	int i;
>   
>   	for (i = 0; i < NUM_JOB_SLOTS; i++)
> 



More information about the dri-devel mailing list