[PATCH] dma-buf: Fix static checker warning
Jianxin Xiong
jianxin.xiong at intel.com
Tue Nov 3 03:51:58 UTC 2020
Here is the warning message:
drivers/dma-buf/dma-buf.c:917 dma_buf_map_attachment()
error: 'sg_table' dereferencing possible ERR_PTR()
Fix by adding error checking before dereferencing the pointer.
Fixes: ac80cd17a615 ("dma-buf: Clarify that dma-buf sg lists are page aligned")
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Jianxin Xiong <jianxin.xiong at intel.com>
---
drivers/dma-buf/dma-buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 556f62e..0eb80c1 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -908,7 +908,7 @@ struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach,
}
#ifdef CONFIG_DMA_API_DEBUG
- {
+ if (!IS_ERR(sg_table)) {
struct scatterlist *sg;
u64 addr;
int len;
--
1.8.3.1
More information about the dri-devel
mailing list