[PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema

Sam Ravnborg sam at ravnborg.org
Thu Nov 5 21:43:49 UTC 2020


Hi Rob/Sameer


On Mon, Nov 02, 2020 at 02:36:54PM -0600, Rob Herring wrote:
> From: Sameer Pujar <spujar at nvidia.com>
> 
> Convert device tree bindings of graph to YAML format. Currently graph.txt
> doc is referenced in multiple files and all of these need to use schema
> references. For now graph.txt is updated to refer to graph.yaml.
> 
> For users of the graph binding, they should reference to the graph
> schema from either 'ports' or 'port' property:
> 
> properties:
>   ports:
>     type: object
>     $ref: graph.yaml#/properties/ports
Please fix so this example is correct - append /schemas/

> 
>     properties:
>       port at 0:
>         description: What data this port has
> 
>       ...
> 
> Or:
> 
> properties:
>   port:
>     description: What data this port has
>     type: object
>     $ref: graph.yaml#/properties/port
Likewise.

Otherwise I could be confused when looking it up later.

> 
> Signed-off-by: Sameer Pujar <spujar at nvidia.com>
> Acked-by: Philipp Zabel <p.zabel at pengutronix.de>
> Signed-off-by: Rob Herring <robh at kernel.org>

With the changelog fixed:
Reviewed-by: Sam Ravnborg <sam at ravnborg.org>


More information about the dri-devel mailing list