[PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue

[Kuo-Hsiang Chou]

To Sir,

Is the mail-address of "daniel.vetter at intel.com" correct for Daniel? 
Because, got the message of " The current directory does not appear to be a linux kernel source tree. " after running get_maintainers.pl
So, find Daniel out by gitk /drivers/gpu/drm/ast

Have a good day,
	Kuo-Hsiang Chou

-----Original Message-----
From: Thomas Zimmermann [mailto:tzimmermann at suse.de] 
Sent: Thursday, November 05, 2020 8:22 PM
To: Kuo-Hsiang Chou <kuohsiang_chou at aspeedtech.com>; dri-devel at lists.freedesktop.org
Cc: Jenmin Yuan <jenmin_yuan at aspeedtech.com>; eich at suse.com; Tommy Huang <tommy_huang at aspeedtech.com>; Arc Sung <arc_sung at aspeedtech.com>; airlied at redhat.com
Subject: Re: [PATCH] drm/ast: Fixed 1920x1080 sync. polarity issue

Hi

Am 05.11.20 um 13:08 schrieb Thomas Zimmermann:
> Hi,
> 
> please follow the advise we're giving you. Had you run 
> scripts/checkpatch.pl on the patch file it would have told you
> 
> <<<
> ERROR: patch seems to be corrupt (line wrapped?)
> #102: FILE: drivers/gpu/drm/ast/ast_tables.h:294:
> 
> 
> ERROR: DOS line endings
> #106: FILE: drivers/gpu/drm/ast/ast_tables.h:297:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | 
> +NewModeInfo |^M$
> 
> ERROR: DOS line endings
> #110: FILE: drivers/gpu/drm/ast/ast_tables.h:300:
> +^I (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | 
> +NewModeInfo |^M$
> 
> total: 3 errors, 0 warnings, 19 lines checked
>>>>
> 

This might not be your fault but the result of my mail client.

> As said before, the mail eich at suse.de is still not relevant any longer.
> But you did not add Daniel into CC. Did you run scripts/get_maintainers.pl?

This still applies.

Best regards
Thomas

> 
> Best regards
> Thomas
> 
> Am 05.11.20 um 10:47 schrieb KuoHsiang Chou:
>> [Bug] Change the vertical synchroous polary of 1920x1080 @60Hz
>>       from  Negtive to Positive
>>
>> Signed-off-by: KuoHsiang Chou <kuohsiang_chou at aspeedtech.com>
>> ---
>>  drivers/gpu/drm/ast/ast_tables.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_tables.h 
>> b/drivers/gpu/drm/ast/ast_tables.h
>> index 8414e543f260..51efc5b4a55c 100644
>> --- a/drivers/gpu/drm/ast/ast_tables.h
>> +++ b/drivers/gpu/drm/ast/ast_tables.h
>> @@ -295,10 +295,10 @@ static const struct ast_vbios_enhtable 
>> res_1600x900[] = {
>>
>>  static const struct ast_vbios_enhtable res_1920x1080[] = {
>>  	{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5,	/* 60Hz */
>> -	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | 
>> +NewModeInfo |
>>  	  AST2500PreCatchCRT), 60, 1, 0x38 },
>>  	{2200, 1920, 88, 44, 1125, 1080, 4, 5, VCLK148_5,	/* 60Hz */
>> -	 (SyncNP | Charx8Dot | LineCompareOff | WideScreenMode | NewModeInfo |
>> +	 (SyncPP | Charx8Dot | LineCompareOff | WideScreenMode | 
>> +NewModeInfo |
>>  	  AST2500PreCatchCRT), 0xFF, 1, 0x38 },  };
>>
>> --
>> 2.18.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer