[PATCH v2] drm/vgem: replace idr_init() by idr_init_base()
Deepak R Varma
mh12gx2825 at gmail.com
Thu Nov 5 17:36:46 UTC 2020
idr_init() uses base 0 which is an invalid identifier. The new function
idr_init_base allows IDR to set the ID lookup from base 1. This avoids
all lookups that otherwise starts from 0 since 0 is always unused.
References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")
Signed-off-by: Deepak R Varma <mh12gx2825 at gmail.com>
---
Changes since v1:
- Changes suggested by Daniel Vetter:
1. Correct typo in patch summary
2. cc intel-gfx to get the patch through CI bot test
drivers/gpu/drm/vgem/vgem_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_fence.c b/drivers/gpu/drm/vgem/vgem_fence.c
index 17f32f550dd9..2902dc6e64fa 100644
--- a/drivers/gpu/drm/vgem/vgem_fence.c
+++ b/drivers/gpu/drm/vgem/vgem_fence.c
@@ -233,7 +233,7 @@ int vgem_fence_signal_ioctl(struct drm_device *dev,
int vgem_fence_open(struct vgem_file *vfile)
{
mutex_init(&vfile->fence_mutex);
- idr_init(&vfile->fence_idr);
+ idr_init_base(&vfile->fence_idr, 1);
return 0;
}
--
2.25.1
More information about the dri-devel
mailing list