[PATCH v3 17/56] drm/omap: panel-dsi-cm: use common MIPI DCS 1.3 defines

[Laurent Pinchart]

Hi Tomi and Sebastian,

Thank you for the patch.

On Thu, Nov 05, 2020 at 02:02:54PM +0200, Tomi Valkeinen wrote:
> From: Sebastian Reichel <sebastian.reichel at collabora.com>
> 
> Drop local definition of common MIPI DCS 1.3 defines.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>
> ---
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> index 25183744a61d..a7236d9c3046 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -28,8 +28,6 @@
>  #include "../dss/omapdss.h"
>  
>  #define DCS_READ_NUM_ERRORS	0x05
> -#define DCS_BRIGHTNESS		0x51
> -#define DCS_CTRL_DISPLAY	0x53
>  #define DCS_GET_ID1		0xda
>  #define DCS_GET_ID2		0xdb
>  #define DCS_GET_ID3		0xdc
> @@ -333,8 +331,10 @@ static int dsicm_bl_update_status(struct backlight_device *dev)
>  		src->ops->dsi.bus_lock(src);
>  
>  		r = dsicm_wake_up(ddata);
> -		if (!r)
> -			r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, level);
> +		if (!r) {
> +			r = dsicm_dcs_write_1(ddata,
> +				MIPI_DCS_SET_DISPLAY_BRIGHTNESS, level);
> +		}

Weird indentation, and no need for curly brackets, but no big deal.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

>  
>  		src->ops->dsi.bus_unlock(src);
>  	}
> @@ -597,11 +597,11 @@ static int dsicm_power_on(struct panel_drv_data *ddata)
>  	if (r)
>  		goto err;
>  
> -	r = dsicm_dcs_write_1(ddata, DCS_BRIGHTNESS, 0xff);
> +	r = dsicm_dcs_write_1(ddata, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, 0xff);
>  	if (r)
>  		goto err;
>  
> -	r = dsicm_dcs_write_1(ddata, DCS_CTRL_DISPLAY,
> +	r = dsicm_dcs_write_1(ddata, MIPI_DCS_WRITE_CONTROL_DISPLAY,
>  			(1<<2) | (1<<5));	/* BL | BCTRL */
>  	if (r)
>  		goto err;

-- 
Regards,

Laurent Pinchart