[PATCH v3 46/56] drm/omap: drop empty omap_encoder helper functions

[Laurent Pinchart]

Hi Tomi and Sebastian,

Thank you for the patch.

On Thu, Nov 05, 2020 at 02:03:23PM +0200, Tomi Valkeinen wrote:
> From: Sebastian Reichel <sebastian.reichel at collabora.com>
> 
> Cleanup empty functions for encoder enable, disable and atomic check.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel at collabora.com>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen at ti.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/omap_encoder.c | 28 --------------------------
>  1 file changed, 28 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_encoder.c b/drivers/gpu/drm/omapdrm/omap_encoder.c
> index 5f5fa01240a7..e24411fb9dac 100644
> --- a/drivers/gpu/drm/omapdrm/omap_encoder.c
> +++ b/drivers/gpu/drm/omapdrm/omap_encoder.c
> @@ -113,36 +113,8 @@ static void omap_encoder_mode_set(struct drm_encoder *encoder,
>  	dss_mgr_set_timings(output, &vm);
>  }
>  
> -static void omap_encoder_disable(struct drm_encoder *encoder)
> -{
> -	struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
> -	struct omap_dss_device *dssdev = omap_encoder->output;
> -	struct drm_device *dev = encoder->dev;
> -
> -	dev_dbg(dev->dev, "disable(%s)\n", dssdev->name);
> -}
> -
> -static void omap_encoder_enable(struct drm_encoder *encoder)
> -{
> -	struct omap_encoder *omap_encoder = to_omap_encoder(encoder);
> -	struct omap_dss_device *dssdev = omap_encoder->output;
> -	struct drm_device *dev = encoder->dev;
> -
> -	dev_dbg(dev->dev, "enable(%s)\n", dssdev->name);
> -}
> -
> -static int omap_encoder_atomic_check(struct drm_encoder *encoder,
> -				     struct drm_crtc_state *crtc_state,
> -				     struct drm_connector_state *conn_state)
> -{
> -	return 0;
> -}
> -
>  static const struct drm_encoder_helper_funcs omap_encoder_helper_funcs = {
>  	.mode_set = omap_encoder_mode_set,
> -	.disable = omap_encoder_disable,
> -	.enable = omap_encoder_enable,
> -	.atomic_check = omap_encoder_atomic_check,
>  };
>  
>  /* initialize encoder */

-- 
Regards,

Laurent Pinchart