[PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning

Lee Jones lee.jones at linaro.org
Fri Nov 13 20:53:47 UTC 2020


On Fri, 13 Nov 2020, 20:50 Daniel Vetter, <daniel at ffwll.ch> wrote:

> On Thu, Nov 12, 2020 at 09:25:16PM +0100, Sam Ravnborg wrote:
> > Hi Lee,
> >
> > On Thu, Nov 12, 2020 at 07:00:11PM +0000, Lee Jones wrote:
> > > The precedent has already been set by other macros in the same file.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > >  drivers/gpu/drm/vkms/vkms_drv.c:55:19: warning: variable ‘crtc’ set
> but not used [-Wunused-but-set-variable]
> > >  55 | struct drm_crtc *crtc;
> > >  | ^~~~
> > >
> > > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > > Cc: Maxime Ripard <mripard at kernel.org>
> > > Cc: Thomas Zimmermann <tzimmermann at suse.de>
> > > Cc: David Airlie <airlied at linux.ie>
> > > Cc: Daniel Vetter <daniel at ffwll.ch>
> > > Cc: Rob Clark <robdclark at gmail.com>
> > > Cc: dri-devel at lists.freedesktop.org
> > > Signed-off-by: Lee Jones <lee.jones at linaro.org>
> >
> > Also applied to drm-misc-next.
> > This was the last patch from this batch I will process.
> > The others are left for the maintainers to pick up.
>
> btw for patches that maintainers don't pick up, the usual process is that
> we give them 2 weeks, then just mass apply. Now you're producing a lot of
> patches, too much for me to keep track, so please just ping me with a
> resend for those that expired and I'll go through and pick them all up.
>

That's great Daniel. Thanks for your support.

I can do one better than that.

Would a pull-request suit you?

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201113/f4b9e3b4/attachment.htm>


More information about the dri-devel mailing list