[PATCH 1/3] drm/panel: s6e63m0: Fix and extend MCS table
Guido Günther
agx at sigxcpu.org
Fri Nov 20 12:02:51 UTC 2020
Hi Linus,
The whole series looks good to me code wise so
Reviewed-by: Guido Günther <agx at sigxcpu.org>
but i have no means to test the changes.
Cheers,
-- Guido
On Tue, Nov 17, 2020 at 06:56:19PM +0100, Linus Walleij wrote:
> Fix up the format of the manufacturer command set table
> to be TAB-indented and lowercase. Add the MCS_TEMP_SWIRE
> command that we will make use of.
>
> Cc: Stephan Gerhold <stephan at gerhold.net>
> Cc: Paweł Chmiel <pawel.mikolaj.chmiel at gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> ---
> drivers/gpu/drm/panel/panel-samsung-s6e63m0.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> index 210e70da3a15..8fce399fb97d 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-s6e63m0.c
> @@ -23,20 +23,21 @@
> #include "panel-samsung-s6e63m0.h"
>
> /* Manufacturer Command Set */
> -#define MCS_ELVSS_ON 0xb1
> -#define MCS_MIECTL1 0xc0
> -#define MCS_BCMODE 0xc1
> +#define MCS_ELVSS_ON 0xb1
> +#define MCS_TEMP_SWIRE 0xb2
> +#define MCS_MIECTL1 0xc0
> +#define MCS_BCMODE 0xc1
> #define MCS_ERROR_CHECK 0xd5
> #define MCS_READ_ID1 0xda
> #define MCS_READ_ID2 0xdb
> #define MCS_READ_ID3 0xdc
> #define MCS_LEVEL_2_KEY 0xf0
> #define MCS_MTP_KEY 0xf1
> -#define MCS_DISCTL 0xf2
> -#define MCS_SRCCTL 0xf6
> -#define MCS_IFCTL 0xf7
> -#define MCS_PANELCTL 0xF8
> -#define MCS_PGAMMACTL 0xfa
> +#define MCS_DISCTL 0xf2
> +#define MCS_SRCCTL 0xf6
> +#define MCS_IFCTL 0xf7
> +#define MCS_PANELCTL 0xf8
> +#define MCS_PGAMMACTL 0xfa
>
> #define S6E63M0_LCD_ID_VALUE_M2 0xA4
> #define S6E63M0_LCD_ID_VALUE_SM2 0xB4
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
More information about the dri-devel
mailing list