[PATCH v2 00/10] drm/fb-helper: Various fixes and cleanups

Maxime Ripard maxime at cerno.tech
Mon Nov 23 09:18:14 UTC 2020


On Fri, Nov 20, 2020 at 11:25:35AM +0100, Thomas Zimmermann wrote:
> Here's a number of fb-helper patches that have been piling up recently.
> 
> Patches 1 to 3 fix bugs that I spotted while going through the code.
> Because of the way the fbdev code works, they have been avoided so far.
> 
> Patches 4 to 10 cleanup damage handling for fbdev's shadow buffer and
> fix a few issues.
> 
> Specifically, the final patch adds locking to the code that flushes the
> shadow framebuffer into BO memory. During the conversion of radeon to
> generic fbdev, the question came up about interference with concurrent
> modesets. If fbdev has the BO pinned in system memory for flushing while
> the modeset wants to pin it to VRAM for scanout, the modeset would
> most likely fail. We haven't seen that so far, but it's possible at
> least. Acquiring the fb-helper lock during the flush operation prevents
> concurrent modesets from taking place.
> 
> The code has been tested with SHMEM and TTM BOs; with atomic and non-
> atomic modesetting.

For the whole series
Acked-by: Maxime Ripard <mripard at kernel.org>

Maxime


More information about the dri-devel mailing list