[PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install

[Thomas Zimmermann]

Hi

Am 26.11.20 um 13:02 schrieb Tian Tao:
> Use devm_drm_irq_install to register interrupts so that
> drm_irq_uninstall is not called when hibmc is removed.
> 
> Signed-off-by: Tian Tao <tiantao6 at hisilicon.com>

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

Thanks!

> ---
>   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index ea3d81b..77792e3 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -247,9 +247,6 @@ static int hibmc_unload(struct drm_device *dev)
>   
>   	drm_atomic_helper_shutdown(dev);
>   
> -	if (dev->irq_enabled)
> -		drm_irq_uninstall(dev);
> -
>   	pci_disable_msi(dev->pdev);
>   	hibmc_kms_fini(priv);
>   	hibmc_mm_fini(priv);
> @@ -284,7 +281,7 @@ static int hibmc_load(struct drm_device *dev)
>   	if (ret) {
>   		drm_warn(dev, "enabling MSI failed: %d\n", ret);
>   	} else {
> -		ret = drm_irq_install(dev, dev->pdev->irq);
> +		ret = devm_drm_irq_install(dev, dev->pdev->irq);
>   		if (ret)
>   			drm_warn(dev, "install irq failed: %d\n", ret);
>   	}
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x680DC11D530B7A23.asc
Type: application/pgp-keys
Size: 7897 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201126/6ff4be1f/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201126/6ff4be1f/attachment.sig>