[PATCH] ARM: locomo: make locomo bus's remove callback return void
Dmitry Torokhov
dmitry.torokhov at gmail.com
Thu Nov 26 21:31:25 UTC 2020
On Thu, Nov 26, 2020 at 12:01:40PM +0100, Uwe Kleine-König wrote:
> The driver core ignores the return value of struct bus_type::remove
> because there is only little that can be done. To simplify the quest to
> make this function return void, let struct locomo_driver::remove return
> void, too. All users already unconditionally return 0, this commit makes
> it obvious that returning an error code is a bad idea and ensures future
> users behave accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> Hello,
>
> if desired the change to arch/arm/mach-sa1100/collie.c can be split out
> of this patch. The change of prototype then doesn't affect this driver
> any more. There is one locomo-driver that is already now unaffected:
> drivers/leds/leds-locomo.c. This driver doesn't have a remove callback.
>
> Best regards
> Uwe
>
> arch/arm/common/locomo.c | 5 ++---
> arch/arm/include/asm/hardware/locomo.h | 2 +-
> arch/arm/mach-sa1100/collie.c | 6 ------
> drivers/input/keyboard/locomokbd.c | 4 +---
Acked-by: Dmitry Torokhov <dmitry.torokhov at gmail.com>
> drivers/video/backlight/locomolcd.c | 3 +--
> 5 files changed, 5 insertions(+), 15 deletions(-)
Thanks.
--
Dmitry
More information about the dri-devel
mailing list