[PATCH v1 01/28] video: Fix W=1 warnings in of_videomode + of_display_timing

Sam Ravnborg sam at ravnborg.org
Sat Nov 28 15:15:34 UTC 2020


Hi Lee,
On Sat, Nov 28, 2020 at 08:28:20AM +0000, Lee Jones wrote:
> On Fri, 27 Nov 2020, Sam Ravnborg wrote:
> 
> > Fix trivial W=1 warnings.
> > Update kernel-doc to avoid the warnings.
> 
> Can you put what's being fixed in the subject line please?
> 
> "fix w=1 warnings" is very bland and this it is unlikely to be the
> only w=1 warning that gets fixed in these files, so has a high likely
> hood of having an identical subject-line as a previous/future patch.
> 
> With regards to the latter point; I have personally found subject
> lines to be a pretty reliable way of maintaining/backporting older
> kernels.  The nomenclature here would taint that pretty readily.

Thanks for the feedback and the background for your comment.
Will fix them all for v2,

	Sam


More information about the dri-devel mailing list