[PATCH v2 28/28] video: fbdev: s1d13xxxfb: Fix kernel-doc and set but not used warnings

Thomas Zimmermann tzimmermann at suse.de
Sun Nov 29 09:59:22 UTC 2020



Am 28.11.20 um 23:41 schrieb Sam Ravnborg:
> Fix following W=1 warnings:
> - Fix set but not nused variables which was used only for logging.

s/nused/used

s/which was/that were

Otherwise

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

>    Fixed by introducing no_printk() to trick compiler to think variables
>    are used
> - Fix kernel-doc warning by deleting an empty comment line
> 
> v2:
>    - Subject updated (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Kristoffer Ericson <kristoffer.ericson at gmail.com>
> Cc: Lee Jones <lee.jones at linaro.org>
> ---
>   drivers/video/fbdev/s1d13xxxfb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/s1d13xxxfb.c b/drivers/video/fbdev/s1d13xxxfb.c
> index 4541afcf9386..d1b5f965bc96 100644
> --- a/drivers/video/fbdev/s1d13xxxfb.c
> +++ b/drivers/video/fbdev/s1d13xxxfb.c
> @@ -45,7 +45,7 @@
>   #if 0
>   #define dbg(fmt, args...) do { printk(KERN_INFO fmt, ## args); } while(0)
>   #else
> -#define dbg(fmt, args...) do { } while (0)
> +#define dbg(fmt, args...) do { no_printk(KERN_INFO fmt, ## args); } while (0)
>   #endif
>   
>   /*
> @@ -512,7 +512,6 @@ s1d13xxxfb_bitblt_copyarea(struct fb_info *info, const struct fb_copyarea *area)
>   }
>   
>   /**
> - *
>    *	s1d13xxxfb_bitblt_solidfill - accelerated solidfill function
>    *	@info : framebuffer structure
>    *	@rect : fb_fillrect structure
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201129/02bdf33d/attachment-0001.sig>


More information about the dri-devel mailing list