[PATCH v2 03/28] video: fbdev: core: Fix kernel-doc warnings in fbmon + fb_notify

[Thomas Zimmermann]

Am 28.11.20 um 23:40 schrieb Sam Ravnborg:
> Fix kernel-doc warnings reported when using W=1
> 
> v2:
>    - Improve subject (Lee)
> 
> Signed-off-by: Sam Ravnborg <sam at ravnborg.org>
> Cc: Lee Jones <lee.jones at linaro.org>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Randy Dunlap <rdunlap at infradead.org>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Cc: "Alexander A. Klimov" <grandmaster at al2klimov.de>
> ---
>   drivers/video/fbdev/core/fb_notify.c | 3 ++-
>   drivers/video/fbdev/core/fbmon.c     | 2 +-
>   2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/fbdev/core/fb_notify.c b/drivers/video/fbdev/core/fb_notify.c
> index 74c2da528884..d85717b6e14a 100644
> --- a/drivers/video/fbdev/core/fb_notify.c
> +++ b/drivers/video/fbdev/core/fb_notify.c
> @@ -38,7 +38,8 @@ EXPORT_SYMBOL(fb_unregister_client);
>   
>   /**
>    * fb_notifier_call_chain - notify clients of fb_events
> - *
> + * @val: value passed to callback
> + * @v: pointer passed to callback

Since you're at it, maybe add Returns.

>    */
>   int fb_notifier_call_chain(unsigned long val, void *v)
>   {
> diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
> index 1bf82dbc9e3c..b0e690f41025 100644
> --- a/drivers/video/fbdev/core/fbmon.c
> +++ b/drivers/video/fbdev/core/fbmon.c
> @@ -605,6 +605,7 @@ static void get_detailed_timing(unsigned char *block,
>    * fb_create_modedb - create video mode database
>    * @edid: EDID data
>    * @dbsize: database size
> + * @specs: monitor specifications, may be NULL
>    *
>    * RETURNS: struct fb_videomode, @dbsize contains length of database
>    *
> @@ -1100,7 +1101,6 @@ static u32 fb_get_hblank_by_hfreq(u32 hfreq, u32 xres)
>    *                                    2 * M
>    *        M = 300;
>    *        C = 30;
> -
>    */
>   static u32 fb_get_hblank_by_dclk(u32 dclk, u32 xres)
>   {
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20201129/5f549a09/attachment.sig>